commit | 48e9a35312885683486b742184e329b3a7bba610 | [log] [tgz] |
---|---|---|
author | Hongchan Choi <hongchan@chromium.org> | Fri Dec 14 19:51:07 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 19:51:07 2018 |
tree | 7e416a30ba3dabd4ac6c7e8a7652eb12debc397b | |
parent | 2008b19d558504cba2f449113fd9ca382618c488 [diff] |
Revert "[unified-consent] Add subpage for sync data type toggles" This reverts commit c62a1965a1ecd3ef8701679df3fbf26186219569. Reason for revert: This CL fails CrSettingsPeoplePageSyncControlsTest.All test. Original change's description: > [unified-consent] Add subpage for sync data type toggles > > - Add advanced sync subpage for configuration of sync > data types. > - Add row "Manage sync" to sync_page that links to this subpage. > - When the user goes through the sign-in flow to customize > settings and navigates to the advanced sync page, sync > doesn't start yet and the snackbar to cancel sync is shown. > When the user leaves the sync and the advanced sync page, > sync will start. > > Additional changes: > - Change "Sync and personalization" to "Sync". > - Change "Manage synced data on Google dashboard" to "Data from Chrome sync". > - Rename people_page_sync_controls.js to people_page_sync_controls_test.js. > > Screenshots: > https://drive.google.com/file/d/1DTa1gcdNc6WihGAawKzHseLEBgpFjegm/view?usp=sharing > https://drive.google.com/file/d/1sn42U_nlkihUhRX2REY1XDBr5YmWxM7C/view?usp=sharing > > TBR=jochen@chromium.org > > Bug: 912598 > Change-Id: Id7b3f7121aac49fe643f3ef14726e98bc40b1ec6 > Reviewed-on: https://chromium-review.googlesource.com/c/1370282 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Scott Chen <scottchen@chromium.org> > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616704} TBR=jochen@chromium.org,scottchen@chromium.org,tangltom@chromium.org Change-Id: Ic24dd9daac4d33fceae69dddc0d2f495d22d8814 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912598 Reviewed-on: https://chromium-review.googlesource.com/c/1378629 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616797}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .