Google Git
Sign in
chromium / chromium / src.git / 785b47089edb5ecbd5ed64b1460445faf233703c
commit785b47089edb5ecbd5ed64b1460445faf233703c[log] [tgz]
authorOmer Katz <omerkatz@chromium.org>Thu Jul 11 22:21:00 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jul 11 22:21:00 2019
tree0f36793058bce233fb1ce329ed294c31b6ccff3d
parente17b055e72d38e0fce3689bd80fea09794f02078 [diff]
Converting WebGLObject from EagerSweeping to PreFinalizers

Replaced WebGLObject's RunDestructor method with a PreFinalize method.
Removed destructors from all classes inheriting from WebGLObject.
PreFinalizer relies on the same virtual methods as the previous
destructor.

Measured performance using tough_webgl stories of rendering.desktop
benchmark. No significant regressions observed.
Summary of results regarding PreFinalization performance:
https://docs.google.com/spreadsheets/d/1vXjVxS5jFT2Bxla8wKzbCXVgUFvKC86WN0vgt0XK8KE/edit?usp=sharing

Bug: 981043
Change-Id: I1ff2762a843c4c443fd0c2f948484a46a0e94738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690834
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676616}
14 files changed
tree: 0f36793058bce233fb1ce329ed294c31b6ccff3d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .