Google Git
Sign in
chromium / chromium / src.git / 7a8d5685bc20ffaf4e094d6ff41b0c67b2bad0a6
commit7a8d5685bc20ffaf4e094d6ff41b0c67b2bad0a6[log] [tgz]
authorJunyi Xiao <juxiao@microsoft.com>Sat Jul 27 01:10:10 2019
committerCommit Bot <commit-bot@chromium.org>Sat Jul 27 01:10:10 2019
treee3870a0005a128179b47f7438c362972fdecf202
parent3460372599919d99fe73761868eec653f00a6d6e [diff]
Devtools: fix a failed aria assertion in ListControl.js

Issue:
Node.prototype.hasSameShadowRoot is used in ARIAUtils to check if two elements are in the same
shadow DOM since aria doesn't work well crossing shadow-boundaries
on occasion where node has not been added to the DOM yet by the time this API get called
(the associated bug is one of the instances), the assertion fails.

This change:
1. fix an issue exposed by the check in ListControl.js

Bug: 978634
Change-Id: Iefd8d3b50272f706b9a5e5310024abeb449ee230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680655
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681569}
1 file changed
tree: e3870a0005a128179b47f7438c362972fdecf202
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .