Google Git
Sign in
chromium / chromium / src.git / 7c6430c11c0b51fe1aa7cfc90e3df67c9b8a7620
commit7c6430c11c0b51fe1aa7cfc90e3df67c9b8a7620[log] [tgz]
authorLeonard Grey <lgrey@chromium.org>Fri Jul 17 15:21:15 2020
committerCommit Bot <commit-bot@chromium.org>Fri Jul 17 15:21:15 2020
tree33e07e4508e7273623fc8477695f6b403573a3e5
parent6cc174b82ede3f8fa32d9bbe5b02e26f4f99eae3 [diff]
Close bookmark menus before executing 'Open All'

When a user command-clicks on a nested bookmark bar folder to open all,
we pop up a dialog to ask if they're sure if the number of tabs that
would be opened exceeds some minimum. Currently, we do this *before*
we dismiss the menu, which (at least on the Mac) closes on a later run
loop as the result of a focus change.

This causes some issues on Mac, including a mouse capture induced
crash and accessibility inconsistencies (see bug for both).

This change disables the code that keeps the bookmark menu open on
background open if the node is a folder.

Bug: 1105587
Change-Id: Iba0ffb0746a9caab0484df22ab40f49ef554ff2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299530
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789490}
1 file changed
tree: 33e07e4508e7273623fc8477695f6b403573a3e5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.