Google Git
Sign in
chromium / chromium / src.git / 800ab60b29e21aa4ef8108612199ad15254ad637
commit800ab60b29e21aa4ef8108612199ad15254ad637[log] [tgz]
authorMatt Falkenhagen <falken@chromium.org>Thu Jul 11 09:40:21 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jul 11 09:40:21 2019
treed05987b9af25e36c29c219edb615d9d58a94754a
parent038517ca6f131974c2ab4740b73017fc56e24bcf [diff]
Fix CaptivePortalBrowserTest's WaitForJobs() function.

It wasn't actually waiting for |num_jobs| when NavigationLoaderOnUI
is enabled. When that feature is enabled, the function is called
directly from the UI thread, and if |ongoing_mock_requests_|
doesn't have size |num_jobs| it would return without waiting.

This was discovered by
https://chromium-review.googlesource.com/c/chromium/src/+/1688592
which will introduce a thread hop in order to perform service worker
interception before doing an outgoing network request, so WaitForJobs()
will be called before a request is added to ongoing_mock_requests_.

Bug: 824858, 978556
Change-Id: I7264f1a4f04e517694417affcd5a8d20d0f4b9b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689979
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676347}
1 file changed
tree: d05987b9af25e36c29c219edb615d9d58a94754a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .