| commit | 827f22ba010c3304d0360227a64378ec79645278 | [log] [tgz] |
|---|---|---|
| author | Charlie Harrison <csharrison@chromium.org> | Mon Jul 20 21:33:59 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 20 21:33:59 2020 |
| tree | 68618d67a1b9035727ef6df5b9b0f1fca8beb1b4 | |
| parent | fccebf91a30c580a234cebe7feb86ac98db26e07 [diff] |
Large cursor fallback: ensure correct coordinate space for OOPIFs A previous change ensured that large custom cursors > 32x32 would be dropped if they are not fully contained with the visual viewport. However, the computation did not account properly for OOPIFs, where cursor coordinates were not adjusted to the viewport offset. This CL further adjusts the cursor rect by translating it to the root view's coordinate space via LocalToAncestorPoint, before checking for containment within the visual viewport. Bug: 1099276 Change-Id: I0a03e7cc249cd785f9e76f931cfc7931b127d56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278597 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#790122}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.