commit | 8e93021e7a68321de6789f1d9efd4a722bd72ac4 | [log] [tgz] |
---|---|---|
author | Julian Kung <juliankung@chromium.org> | Fri Jun 28 02:31:21 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 28 02:31:21 2019 |
tree | 1d1055c6ca712c0c27a484d53e20c278e3c6c29c | |
parent | 4e6d210d285be648516b4c4cfbf10ddcff2f2f4f [diff] |
[ChromeDriver] Added support for headless mode to download files Previously, Chromedriver running in headless mode would not properly download files due to the fact it sparsely parses the preference file given to it. Engineers from the headless chrome team recommended using DevTools's "Page.setDownloadBehavior" to fix this. This changelist implements this fix. Downloaded files default to the current directory and can be set using download_dir when instantiating a chromedriver instance. Also added tests to ensure proper download functionality. R=johnchen@chromium.org, crouleau@chromium.org Bug: chromedriver:2454 Change-Id: Ic80968154400de11df8034bfb5e50280e31d126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670161 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673194}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .