Google Git
Sign in
chromium / chromium / src.git / 46de48d287c6eaf2f811b47312e3f2f0d9532e01
commit46de48d287c6eaf2f811b47312e3f2f0d9532e01[log] [tgz]
authorYi Gu <yigu@chromium.org>Wed Jun 06 13:29:23 2018
committerYi Gu <yigu@chromium.org>Wed Jun 06 13:29:23 2018
tree2ac0d9532ace0f4a6dfbf138ea97cc6af354aeb3
parent243eea5e9018942e5333515689d612d612a399f5 [diff]
Compute correct sticky box constraints within scrollable containers

Currently calculating the skipped offset between sticky and its
containing block assumes that the latter is not scrollable. However,
when it is we should ignore the scroll offset from the container
otherwise scrolling the container would cause the sticky offset
incorrectly double accumulated.

Bug: 841551
Change-Id: Ib49aaa74808847dcf6fce7dc0db9ac4d2de06c64
Reviewed-on: https://chromium-review.googlesource.com/1054488
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564276}(cherry picked from commit d5270f6e22964848928f2f6a6d2263d012186e24)
Reviewed-on: https://chromium-review.googlesource.com/1087333
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#209}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
14 files changed
tree: 2ac0d9532ace0f4a6dfbf138ea97cc6af354aeb3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .