| commit | 962cbbe81708214ff8e14e2bc8a07271cb15f1b9 | [log] [tgz] |
|---|---|---|
| author | Hans Wennborg <hans@chromium.org> | Wed Nov 04 02:06:44 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 04 02:06:44 2020 |
| tree | 1414125584b605a6557d660b099ed3f3cd4c212e | |
| parent | aa7e9790eb89c5366551f438f3e111cdae41a567 [diff] |
[zlib] Zero-initialize the window used for deflation Otherwise MSan complains about use-of-uninitialized values in the window. This happens in both regular deflate's longest_match and deflate_rle. Before crrev.com/822755 we used to suppress those reports, but it seems better to fix it properly. That will also allow us to catch other potential issues with MSan in these functions. The instances of this that we've seen only reproduce with fill_window_sse(), not with the regular fill_window() function. Since the former doesn't exist in upstream zlib, I'm not planning to send this patch upstream. Bug: 1137613, 1144420 Change-Id: I2b1801cd2a63fef48a0072b2d2c8fc1f8a7bb920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517520 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#823845}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.