commit 96fd0d1473327a8bfed71c3ec8b3cfb472f9a805
author Asami Doi <asamidoi@chromium.org> Mon Mar 07 06:41:31 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 07 06:41:31 2022
tree 5e2ccf108c1ba394b0b10027da860ce392282412
parent ce4c678ee832a22c1f1113b234a5d16206bc6099

Reland "Prerender: move the impl of prerender from AAP to PrerenderManager"

This is a reland of commit 8d00717877010be3f7caa99d1aa3e46c634360c9
The original CL was reverted because
PrerenderOmniboxSearchSuggestionUIBrowserTest tests failed.
https://chromium-review.googlesource.com/c/chromium/src/+/3501376

Example test failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/125336/overview

We didn't wait for the initialization of AutocompleteActionPredictor
and didn't collect histogram data for DUI in the original CL.
It led test failures.

The diff from the original CL is removing the checks for
kHistogramPrerenderPredictionStatusDirectUrlInput
("AutocompleteActionPredictor.PrerenderStatus" in this CL) from
failing test cases. It's ok because the failure cases checks if DSE
works and it doesn't relate to DUI.

Original change's description:
> Prerender: move the impl of prerender from AAP to PrerenderManager
>
> This CL refactors AutocompleteActionPredictor (AAP) by moving the
> following implementation:
>
> - the logic to start prerendering for default search engine (DSE). This
> is moved to ChromeOmniboxClient::DoPrerender() and
> OmniboxPrerender::DoPrerender(). This was the previous behavior
> changed in https://crrev.com/c/3439445
> - the logic to record kNotStarted for DSE. This is moved to
> ChromeOmniboxClient::OnURLOpenedFromOmnibox() and
> AutocompleteControllerAndroid::OnSuggestionSelected().
> - the logic to record kHitFinished/kUnused for direct URL input (DUI).
> This is moved to PrerenderManager::PrimaryPageChanged().
> - the logic to record kCancelled for DUI. This is moved to
> PrerenderManager::StartPrerenderDirectUrlInput().
>
> This changes lead the incompatibility of precision/recall between
> NSP and Prerender but I think it's not a problem for now.
> See https://crbug.com/1300416.
>
> Bug: 1297441, 1295188, 1300416
> Change-Id: I65e60488df898b792b56fb4dba54bbe97e6d91c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3467215
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Huanpo Lin <robertlin@chromium.org>
> Reviewed-by: Lingqi Chi <lingqi@chromium.org>
> Commit-Queue: Asami Doi <asamidoi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#976968}

Bug: 1297441, 1295188, 1300416, 1302539
Change-Id: Ied62a9eeba38d352dccd9915a11d8d25786b0fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501378
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Huanpo Lin <robertlin@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978163}