Google Git
Sign in
chromium / chromium / src.git / 987282a4a242d3a913e7ec6f5c2065cf0df7ac9c
commit987282a4a242d3a913e7ec6f5c2065cf0df7ac9c[log] [tgz]
authorRune Lillesveen <futhark@chromium.org>Fri Aug 02 11:54:10 2019
committerCommit Bot <commit-bot@chromium.org>Fri Aug 02 11:54:10 2019
treeedf4d32b34ad0fa5bb53170c3d212833040d787b
parent329c91e5a188f8f9572b2a37e4614508f8168635 [diff]
Update layout tree rebuild root after removing pseudo element.

We tried to avoid marking the pseudo element when it was about to be
removed, but the pseudo element earlied out before removal if it wasn't
marked for re-attachment causing the element not to be removed.

Notify the StyleEngine about removal instead, so that it can update the
traversal root. For normal elements the StyleEngine is notified through
ChildrenRemoved().

Bug: 989894
Change-Id: Ia2bf52c9bed157c4ac806a10b9367b0f99038974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732096
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683543}
3 files changed
tree: edf4d32b34ad0fa5bb53170c3d212833040d787b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .