commit | 1a18c3f0a0728393139bc10efdf7b866c61fd605 | [log] [tgz] |
---|---|---|
author | Darren Shen <shend@chromium.org> | Thu Jun 14 14:05:53 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 14 14:05:53 2018 |
tree | b9252ac35279a2db634256bca24485f0184b1528 | |
parent | 54b4f8dc66a7aa94f9f5e714c8df810a46cef5ef [diff] |
[VK] Use semantically-correct bounds when querying keyboard bounds. There are several places where we query the keyboard bounds by grabbing the keyboard container window and calling |bounds|. However, it's unclear whether they mean the bounds relative to parent or bounds relative to the screen, since both are currently the same for the keyboard container. This patch changes several callers to use |GetBoundsInScreen| since they actually want the screen bounds. Note we don't change any behaviour since currently keyboard container |bounds| == |GetBoundsInScreen|, but this will change in future when we get rid of keyboard container. Bug: 849980 Change-Id: I7211073a7697f168824c127319dfc40e6888195a Reviewed-on: https://chromium-review.googlesource.com/1098417 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567253}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .