commit | 26cb83100da5fa2a764cc59e8a7aafdee43cae0f | [log] [tgz] |
---|---|---|
author | Brian Sheedy <bsheedy@chromium.org> | Tue Jun 18 18:29:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jun 18 18:29:01 2019 |
tree | 38ddc4717855f773968e77922043d4bc46e7d0b4 | |
parent | 0ccd9303debf7cb25b24d27f7b5d7beb515a0360 [diff] |
Revert "[AdTagging] Add support for asynchronous stacks in AdTagging" This reverts commit 449843402d48f32834e1205e8c624c69cfee40ee. Reason for revert: crbug.com/976331 Original change's description: > [AdTagging] Add support for asynchronous stacks in AdTagging > > What: Label async tasks as ad or not. > > Why: So that the AdTracker knows if a running task is due to an async > task registered while ad script was on the stack. > > How: Modified the async probes to take a AsyncTaskId* instead of a > void*. The AsyncTaskId* stores the bit of whether ad script was on > the stack at the time of creation. This is *much* better than the > previous approach (https://crrev.com/c/1291232) in that there are no > memory leaks, no extra map lookups, and we don't have to worry about > cancelasynctask being called. It does require a modification to all > probe locations to hold a AsyncTaskId member. > > Bug: 851531 > Change-Id: I92e25b3ab3b8746611c3a3f9a9a7265bab4a601e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648886 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669884} TBR=dgozman@chromium.org,alph@chromium.org,japhet@chromium.org,jkarlin@chromium.org Change-Id: I36397d0e78d33fb3522301ff4e11b27cb679fdda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664201 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670140}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .