Google Git
Sign in
chromium / chromium / src.git / 28ac1ad78705bdbbfe2a11f7bf0e4138e7301d06
commit28ac1ad78705bdbbfe2a11f7bf0e4138e7301d06[log] [tgz]
authorThomas Tangl <tangltom@chromium.org>Sun Aug 19 19:18:08 2018
committerCommit Bot <commit-bot@chromium.org>Sun Aug 19 19:18:08 2018
treee2051ec67d609f0f0c4c26aeda1c38a44360a032
parente33fda00811b2fde69f435d74af225e83e8f0f30 [diff]
[unified-consent] Refactor migration code and add settings updates

The migration code in the UnifiedConsentService is refactored:
 - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is
 extracted to it's own pref kShouldShowUnifiedConsentBump.
 - The migration state kInProgressWaitForSyncInit is introduced
 to be able to update the settings for migration when sync is
 initialized.

Additional changes:
 - ShouldShowConsentBump only returns true if the consent bump
 feature is enabled.
 - The rollback enables sync-everything now also when the user is
 not syncing USER_EVENTS (which is disabled during the migration).

Users that previously had the unified consent feature enabled and
for which ShouldShowConsentBump=true, will not be shown the consent
bump anymore after this CL is landed. This will only affect a few
users on Canary and Dev.

Bug: 863932
Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c
Reviewed-on: https://chromium-review.googlesource.com/1172690
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584341}
6 files changed
tree: e2051ec67d609f0f0c4c26aeda1c38a44360a032
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .