Add traffic annotation to download Plugin VM image request
Defines plugin_vm_image_download traffic annotation and adds it to the
corresponding request.
Bug: 966399
Change-Id: Iefbc4a6f11385aaf80f99971c7365872297a0c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648162
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668027}
diff --git a/chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.cc b/chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.cc
index 4aadc6da..7a9acee 100644
--- a/chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.cc
+++ b/chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.cc
@@ -461,12 +461,33 @@
params.guid = base::GenerateGUID();
params.callback = base::BindRepeating(&PluginVmImageManager::OnStartDownload,
weak_ptr_factory_.GetWeakPtr());
- // TODO(https://crbug.com/966399): Create annotation.
+
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("plugin_vm_image_download", R"(
+ semantics {
+ sender: "Plugin VM image manager"
+ description: "Request to download Plugin VM image is sent in order "
+ "to allow user to run Plugin VM."
+ trigger: "User clicking on Plugin VM icon when Plugin VM is not yet "
+ "installed."
+ data: "Request to download Plugin VM image. Sends cookies to "
+ "authenticate the user."
+ destination: WEBSITE
+ }
+ policy {
+ cookies_allowed: YES
+ cookies_store: "user"
+ chrome_policy {
+ PluginVmImage {
+ PluginVmImage: "{'url': 'example.com', 'hash': 'sha256hash'}"
+ }
+ }
+ }
+ )");
params.traffic_annotation =
- net::MutableNetworkTrafficAnnotationTag(NO_TRAFFIC_ANNOTATION_YET);
+ net::MutableNetworkTrafficAnnotationTag(traffic_annotation);
// RequestParams
-
params.request_params.url = url;
params.request_params.method = "GET";