Google Git
Sign in
chromium / chromium / src.git / aacf7691537c820560c5784c77d77c84013a79ff
commitaacf7691537c820560c5784c77d77c84013a79ff[log] [tgz]
authorDan Harrington <harringtond@chromium.org>Thu Apr 04 22:36:21 2019
committerCommit Bot <commit-bot@chromium.org>Thu Apr 04 22:36:21 2019
treec7fdd388327019da88ff1527c2327c9e99f55690
parent54d690b417830bc66c6e14625ae3220822815d40 [diff]
Remove unsafe int->enum casts

In each case, we're storing integers in a database and casting to the enum
when reading from the database. If the database is corrupt (or if we add an enum
value and then the user downgrades), we're at risk of crashing later on.

This should fix all occurences within offline_pages/

Bug: 944674
Change-Id: I37491a6aa132feef6e8e13f66f1734a18013acdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534472
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#647952}
11 files changed
tree: c7fdd388327019da88ff1527c2327c9e99f55690
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .