| commit | abe3b85fcec8f12c708fdbb8146957aae475e69e | [log] [tgz] |
|---|---|---|
| author | Mike Wasserman <msw@chromium.org> | Wed Oct 07 22:38:38 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 07 22:38:38 2020 |
| tree | 3e45dcbb271023e3eb140f065c656adbf5bbe63b | |
| parent | 0f519f42121c9697fc4b3a59ac58d2154157cc21 [diff] |
Window Placement: Allow requestFullscreen from onscreenschange
Similar to allowing requestFullscreen on screen orientation changes.
Allows sites to requestFullscreen when the user changes screen config
(e.g. when the user connects an external display to a laptop)
Add TransientAllowFullscreen for async support like UserActivationState.
(ScopedAllowFullscreen only supports sync, stack-allocation scopes)
Add a basic unit test for the new class, and an integration test.
(cherry picked from commit db8f4f0a098d52c66855b62234ecec005e1ff572)
Bug: 1077402
Test: window.onscreenschange = async () => { element.requestFullscreen({screen:(await getScreens())[1]}); };
Change-Id: Iffc5bb419e2b016704b923bd8454cb422672b5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429967
Commit-Queue: Michael Wasserman <msw@chromium.org>
Auto-Submit: Michael Wasserman <msw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#814036}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458777
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/branch-heads/4280@{#109}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.