commit | ad7f4a1eb0e48e3dab09b3695d97f64c101f54ab | [log] [tgz] |
---|---|---|
author | Erik Chen <erikchen@chromium.org> | Mon Aug 05 20:38:05 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 05 20:38:05 2019 |
tree | 41a9c3ddff5d53110208ed1ad1bef4580e01366f | |
parent | 2261cbe79fb40545cbeba8617c277685960ceb44 [diff] |
Move BrowserControl methods from WebLayerTreeView to WebWidgetClient. We are removing the WebLayerTreeView interface as it is redundant with WebWidgetClient now that we always composite web contents. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. This CL is mostly a refactor but has a slight behavior change. WebViewImpl::DidUpdateBrowserControls had a conditional gated on layer_tree_view_. This CL replaces the conditional with a check for local main frame. Change-Id: Iaab168eaef0aa2b396f92e9d2cd049176d4efbf9 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728339 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#684097}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .