commit | af565e883475b6762367a2b0d97dc8bcd71c07f1 | [log] [tgz] |
---|---|---|
author | Jon Mann <jonmann@chromium.org> | Tue Jun 18 00:27:19 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jun 18 00:27:19 2019 |
tree | 972393a6b3c058b6a8651bfbc5ae886b9ab37d38 | |
parent | 5e85aa3668218fa4e488bc9e82ca1d0c478171eb [diff] |
Remove IP address from top level cellular network page. This field is now only shown under the "Network" details pane. Bug: 924246 Change-Id: Ibdd6d722d26792a2ab108392721ae88a0abb2fb6 Screenshot: https://screenshot.googleplex.com/24ayhPiZrWw.png Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663076 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#669911}
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js index abf4d55..d7522a5 100644 --- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js +++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -1534,6 +1534,11 @@ return false; } + // Cellular IP addresses are shown under the network details section. + if (this.isCellular_(networkProperties)) { + return false; + } + return !!ipAddress && this.isConnectedState_(networkProperties); },