Google Git
Sign in
chromium / chromium / src.git / b229201c9e85683e55620e2be1104f8f58edad31
commitb229201c9e85683e55620e2be1104f8f58edad31[log] [tgz]
authorMichael Lippautz <mlippautz@chromium.org>Thu Jul 18 11:11:16 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jul 18 11:11:16 2019
treeb36ee3960c8734b39fdd9dd0ddc17851461f1300
parent901c35e77b58c86b80b40780c4c6a929f12e57a1 [diff]
bindings: Initialize heap before allocating objects during setup

V8 may trigger incremental garbage collections as setup code is
allocating objects. Since the embedder tracing mechanism was only set up
after initializing the GC cycle, this may lead to memory corruptions
during GC.

Bug: 984936
Change-Id: I36af7bf5675b0b51ee2379ed8804a244f5fe424d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708076
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678642}
1 file changed
tree: b36ee3960c8734b39fdd9dd0ddc17851461f1300
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .