Google Git
Sign in
chromium / chromium / src.git / c14bba7555f72753930dcbd93bc3f59acb291728
commitc14bba7555f72753930dcbd93bc3f59acb291728[log] [tgz]
authorDrew Stonebraker <stonebraker@chromium.org>Thu Mar 28 00:11:22 2019
committerCommit Bot <commit-bot@chromium.org>Thu Mar 28 00:11:22 2019
tree5cfa24e451f1af4316d74b41c75060a485ae2863
parent7e126d67b837e8838f7ab4c0a37067ab07f28480 [diff]
Refactor gn versionCode logic and add tests

Refactor existing chrome for android and webview version code
logic from build/config/android/chrome_version.gni to a python
script and add unit tests (in PRESUBMIT).

Bug: 938138, 945039
Test: Add unit tests in PRESUBMIT; manually verify versionCode
Test: values in manifest.xml using Android Studio apk analyzer
Change-Id: I6537c8f2d4d1f6ee9a18c43f253b69de0afe674a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501459
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645096}
13 files changed
tree: 5cfa24e451f1af4316d74b41c75060a485ae2863
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .