commit c29eaf12c34aec13ef24b670f9d61d08e19216ce
author Martin Kreichgauer <martinkr@chromium.org> Wed Jul 24 01:37:27 2019
committer Commit Bot <commit-bot@chromium.org> Wed Jul 24 01:37:27 2019
tree 7318de15b20cdd58eb0992f41606dcaf2b2941a8
parent 432ffabdf4b9c6b1f0717707b2d46dfb7b9d7cea

win: don't show an error dialog after cancelling out of Win WebAuthn UI

This fixes a regression that caused cancelling out of the native Windows
WebAuthn UI would show an error dialog, when the request should have
just been ended right away.

The error dialog in question contained a "retry" button, which was non-
functional because it just returned the UI to an empty transport
selection UI. Conceptually, we don't want to offer the "retry" button on
Windows, because the Windows UI brings its own retry behavior for
certain cases (e.g. user touched the wrong security key). Hence, this
change also extends the retry logic on
ChromeAuthenticatorRequestDelegate to hide retry buttons after
dispatching a request to the Windows API.

Bug: 985597
Change-Id: Ie02721068c847156222e81f193fd446929ca996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710741
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680277}