Revert "Reland "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag""

This reverts commit 8bb448c9258fc30586ddde68bdd9015feb8a29f0.

Reason for revert: broke compilation: https://ci.chromium.org/p/chromium/builders/ci/android-dbg/4941

Original change's description:
> Reland "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag"
> 
> This reverts commit 22829656360424a1b416b0d91af94475bc9242ed.
> 
> Reason for revert: Reland with fix in blink_x86_avx source_set deps.
> 
> Original change's description:
> > Revert "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag"
> >
> > This reverts commit 3553b590b10065867cc4d349e1485e5c8478e68a.
> >
> > Reason for revert: Causing win-rel compile error.
> >
> > Original change's description:
> > > base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag
> > >
> > > Currently NOTREACHED() uses LogErrorNotReached() on ChromeOS for release
> > > builds, and DCHECK(false) otherwise. However, there are other projects
> > > depending on Chromium that would prefer using DCHECK(false) in all cases,
> > > and currently there's no easy way to do so.
> > >
> > > This CL adds an |enable_log_error_not_reached| gn arg to control whether
> > > to use LogErrorNotReached() for NOTREACHED() to solve this problem. It
> > > is enabled by default only for ChromeOS release builds to keep the
> > > current behavior.
> > >
> > > Bug: 760393
> > > Change-Id: I512227563d8ad4a08a8d7b5d1ec966a8aacbcc08
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586593
> > > Reviewed-by: Nico Weber <thakis@chromium.org>
> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#655701}
> >
> > TBR=thakis@chromium.org,xhwang@chromium.org
> >
> > Change-Id: Iadcee95984e8783f26aeb687dc1cd31f9186e03d
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 760393
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592478
> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#655714}
> 
> TBR=thakis@chromium.org,xhwang@chromium.org
> 
> Change-Id: Idd16cea9c37cdf5bb5f0b7dbac9d5b974c8c4b63
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 760393
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592861
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656476}

TBR=thakis@chromium.org,xhwang@chromium.org

Change-Id: I28e50016a417d21344682856f08e87338ce7ceb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594205
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656479}
6 files changed