| commit | c998b145d80aec8b6771f828114677c8f6cc07f5 | [log] [tgz] |
|---|---|---|
| author | Adam Bujalski <abujalski@gmail.com> | Wed Aug 21 16:35:57 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Aug 21 16:35:57 2019 |
| tree | 03e7536597846a8d4f1378f5907b612b83a40792 | |
| parent | 85ba75d1f8c1319ec546f3625a03ddea54779bd3 [diff] |
Memory leaks during re-creating NaCl modules This patch fixes one of three memory leaks found when page reloads NaCl module(s). In PepperPluginInstanceImpl ctor FrameHostMsg_DidCreateInProcessInstance message is sent to browser process, however message FrameHostMsg_DidDeleteInProcessInstance isn't sent from dtor. This is because PepperPluginInstanceImpl is created for unproxied module and later reinitialized as proxied one, which causes that PepperBrowserConnection::DidCreateInProcessInstance method is called in PepperPluginInstanceImpl ctor, however PepperBrowserConnection::DidDeleteInProcessInstance isn't called in PepperPluginInstanceImpl dtor. Bug: 922925 Change-Id: Ifb80108a99f591e7d30ec8013e94cef6d176eca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679692 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#689031}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .