Google Git
Sign in
chromium / chromium / src.git / bd157bae8521ef57be94e447d9e9db8897bba0dc
commitbd157bae8521ef57be94e447d9e9db8897bba0dc[log] [tgz]
authorChris Lu <thegreenfrog@chromium.org>Tue Aug 18 18:01:45 2020
committerCommit Bot <commit-bot@chromium.org>Tue Aug 18 18:01:45 2020
treee0e3af0f07d4e0be62ce9e58f23bff55ab7995fb
parente9cef07a24fa39584e093e880f9f1dd511e3901c [diff]
[ios] Move presenting_ DCHECK to after presentation context checks

It is no longer true that presenting_ will always be false when
PresentOverlayForActiveRequest is called. This can occur if the
current active request is dismissed by being removed from the queue
and adds another overlay in its completion callback. Instead, the
DCHECK can be moved after the OverlayPresentationContext checks,
which should be enough to early return when an overlay is already
being presented.

Bug: 1114547
Change-Id: I1756df163dfb10e96537449491d0cfc5295c4aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360376
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799195}
1 file changed
tree: e0e3af0f07d4e0be62ce9e58f23bff55ab7995fb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.