commit | cbc90fd09395613d956277e4ae33b5eeea7820d7 | [log] [tgz] |
---|---|---|
author | Mirko Bonadei <mbonadei@chromium.org> | Thu Nov 14 22:26:17 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 14 22:26:17 2019 |
tree | fa124c360645e3fc7a652fa6b68baa6c0aa7c68c | |
parent | eaf6dceed917e79c1fd9ea46510906d9f0e49736 [diff] |
Introduce WebRTC component build. This CL switches all the Chromium dependencies from being direct dependencies on WebRTC targets to a WebRTC component (which lives at //third_party/webrtc_overrides:webrtc_component). From now on, Chromium should never directly depend on WebRTC in order to avoid issues explained at [1] (this will be guarded by checkdeps and GN visibility (see [2])) but should only depend on the WebRTC component. This should solve a broad range of problems caused by WebRTC being linked in different shared libraries when is_component_build=true (from globals and singletons causing hard to debug issues, to ODR violations and binary size increase). [1] - https://chromium.googlesource.com/chromium/src.git/+/master/docs/component_build.md#dependencies-between-targets [2] - https://webrtc-review.googlesource.com/c/src/+/154344 TBR: dcheng@chromium.org Bug: webrtc:9419 Change-Id: Ice56827db1753f51592165a90c1094b468c8e188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874722 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715450}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .