Google Git
Sign in
chromium / chromium / src.git / df9f8d87abe15ed4d2e96f07565bc7202c5831f3
commitdf9f8d87abe15ed4d2e96f07565bc7202c5831f3[log] [tgz]
authorJonathan Ross <jonross@chromium.org>Thu Nov 29 21:47:25 2018
committerCommit Bot <commit-bot@chromium.org>Thu Nov 29 21:47:25 2018
tree711326acec0c814e8eb0803e5d9ee78eaa438522
parentdfe266e269441ae61b64272e5550d44a2c3f7faf [diff]
Reduce DelegatedFrameHost NOTIMPLEMENTED Calls

RenderWidgetHostViewMac explicitly sets NeedsBeginFrames upon startup.
This was setup to address some race condition.

However this is not handled by the browser process when Viz Display
Compositor is enabled. DelegatedFrameHost is spamming debug logs with
NOTIMPLEMENTED messages as a result.

All other paths to this is already checking the Viz status and not
calling in. Once Viz has launched we'll remove this legacy path.

This change updates RenderWidgetHostViewMac to not explicitly set
NeedsBeginFrames upon startup when Viz Display Compositor is
enabled.

Bug: 907246
Change-Id: I9a584c4bedcdb1da897f8155eb151ff63ef3c8b2
Reviewed-on: https://chromium-review.googlesource.com/c/1355479
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612386}
1 file changed
tree: 711326acec0c814e8eb0803e5d9ee78eaa438522
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .