Google Git
Sign in
chromium / chromium / src.git / e01e7fe64089d3998a762e254bd3ffc1a882a671
commite01e7fe64089d3998a762e254bd3ffc1a882a671[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Wed Apr 17 18:49:08 2019
committerCommit Bot <commit-bot@chromium.org>Wed Apr 17 18:49:08 2019
tree4e560b3e000cb6aa42aebf93189bec6fcde9993e
parentaac5a6823905c1d0c8d2c946e2adb73ee2aa7ff9 [diff]
Omnibox: After unelision, ignore tiny drags until mouseup

Right now, when the user double-clicks a word within an elided URL, we
trigger unelision on the second mousedown. During unelision, the text
shifts. If the mouse moves at all during the second mouseup, the
selection may change unexpectedly.

This is ordinarily not a problem, but since the text has shifted
underneath the user, even tiny mouse movements can cause large
selection changes.

This CL fixes that by applying a minimum threshold to any drag
movements (8px). Any drag movements smaller than that are ignored.
This threshold is active until mouseup.

Bug: 951447
Change-Id: I584b827e408e2d03e20d76bb0bd3b038e193e80c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570571
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651829}
3 files changed
tree: 4e560b3e000cb6aa42aebf93189bec6fcde9993e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .