commit ef449d5fc28f463b62039ec0fc850c25f51ad801
author David Benjamin <davidben@chromium.org> Thu Jul 30 17:29:50 2020
committer Commit Bot <commit-bot@chromium.org> Thu Jul 30 17:29:50 2020
tree d90e5949975aaeeb034f190aca87fecec851e2ef
parent 5f30a270ef998df1da71e307455bfcc7c6ca138f

Switch macOS to the views client certificate selector

Now that we are using views on Mac, we can use the same client
certificate selector used on CrOS, Linux, and Windows. This means less
code to maintain, and it also avoids a host of bugs with the
tab-constrained sheet logic which has become increasingly buggy as
Chrome and macOS have evolved. (See associated bugs.)

This retains tab-modality, so sites cannot prevent tab switching or tab
closing, but it switches us from the native sheet to our own UI.

Screenshots:
https://drive.google.com/drive/folders/1YlVAWm-xL8ZDP9k-amdBb4l18nh08rJZ?usp=sharing

This should leave parts of components/constrained_window and
ClientCertIdentity::sec_identity_ref unused. A follow-up CL will unwind
that logic.

Bug: 983451, 1020622, 1078158, 1098786
Change-Id: I9b2ea99a91e63e45934725dead6bade35ec3ca4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314036
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793238}