Google Git
Sign in
chromium / chromium / src.git / ff9f227d2b5cf53595e9157c4cf60dd0458e1028
commitff9f227d2b5cf53595e9157c4cf60dd0458e1028[log] [tgz]
authorSebastien Lalancette <seblalancette@chromium.org>Wed May 27 08:56:08 2020
committerCommit Bot <commit-bot@chromium.org>Wed May 27 08:56:08 2020
treef81c6528894d857775f4f8c78e43abce7cf46f51
parentbd57436c85636c1ff62fc83f0deca55282437c0a [diff]
[iOS] Fix 13.5 ConfirmationAlertViewController Toolbar Done Button

When going from compact width to regular width, we swap the toolbar
buttons. This allows us to add/remove buttons based on the screen
constraints. Before iOS 13.5, setting the "items" property of a
UIToolbar worked fine. However, in 13.5, this made the last button
(Done button) to become non-responsive when going from compact width
to regular width.

Somehow, using the setItems:animated API fixes the issue.

Tested on simulators:
iPhone 13.5 and 12.4
iPAD 13.5 and 12.4

Bug: 1082723
Change-Id: Icde5b6760038560f9f8601af1afc328a4e2e4aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216285
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772160}
1 file changed
tree: f81c6528894d857775f4f8c78e43abce7cf46f51
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.