Google Git
Sign in
chromium / chromium / src.git / 06d79df07ef1c65187ab1cf23b115b4019485052
commit06d79df07ef1c65187ab1cf23b115b4019485052[log] [tgz]
authorLukasz Anforowicz <lukasza@chromium.org>Thu May 14 13:56:04 2020
committerCommit Bot <commit-bot@chromium.org>Thu May 14 13:56:04 2020
tree4637c0524c33d839386e7ce68f4b23696295d161
parent525927b516607d0c51fee2c0d74f1fd86b927320 [diff]
Not generating replacements within implicit template specializations.

In template specializations template parameters (e.g. |T| or |T2| in
MyTemplate in tests/template-specializations-original.cc) get
substituted with an actual class (e.g. |SomeClass| or |int|).  In an
*implicit* specialization, these substitutions are "overlaid" /
"overimposed" on top of the template definition and this can lead to
generating conflicting replacements - for example the same |t_ptr_field|
definition can get replaced with:
1. T* t_ptr_field  ->  CheckedPtr<T> t_ptr_field            // expected
2. T* t_ptr_field  ->  CheckedPtr<SomeClass> t_ptr_field    // undesired

After this CL, the FieldDecls in an implicit template specialization
(i.e.  example2 above) are ignored.  This avoids generating a
conflicting replacement.

Bug: 1069567
Change-Id: I8d2487fdece703421ceb08be67bf6f817e44c03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156068
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768748}
3 files changed
tree: 4637c0524c33d839386e7ce68f4b23696295d161
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.