commit efca1917701b0c85a0d7c3316eadaf179dbf1cc7
author Trent Apted <tapted@chromium.org> Thu Aug 09 05:08:31 2018
committer Commit Bot <commit-bot@chromium.org> Thu Aug 09 05:08:31 2018
tree 724082287fcfd408cbabec8767afe01cc7857426
parent 070d9fe4b6dec96c4c155289def06f095aa9e26a

FileManager: Generate unit test html files from closure dependencies.

JS files don't name their `#includes`, but for closure compilation we
must effectively list each .js file's #includes in build dependencies.
We can use this to generate the list of .js files, in the correct
order, that we use for js unittests. Manually creating the
foo_unittest.html files is fiddly, error-prone, and is not robust to
files being moved around. However, it does require the unittest js
file to be properly closure-compiled.

Start by obsoleting the 3 foo_unittest.html files in
gallery/image_editor, which are the only ones currently closure-
compiled.

Note that the dependency files are created _regardless_ of the
`closure_compilation = true` gn flag. i.e. this does not introduce a
dependency on the closure _compiler_: dependency information comes from
the GN build files alone. The closure_compilation flag only affects the
js_type_check(..) targets, but the approach here uses js_library(..)
targets.

Bug: 867700
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I91b3a726b999a9f7db721fefc23b3f6512fd3c0c
Reviewed-on: https://chromium-review.googlesource.com/1161720
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581795}