commit | f0d63432c51741e6dc0bf48f0b84e4afb63f887f | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Fri Oct 12 13:42:49 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 13:42:49 2018 |
tree | 60c656ab256acaaee38dda63849c59ac08e45981 | |
parent | 1b71114eba7ab4e982eaf03186b12503c8ca49c4 [diff] |
ProfileSyncService cleanup: Remove platform_sync_allowed_provider_ ProfileSyncService::platform_sync_allowed_provider_ was a callback that returned whether Android's "Master Sync" toggle is enabled, and so Sync shouldn't start up. However, PSS didn't know when the value changed, so the callback was kinda useless, and PSS could easily get into an inconsistent state (where there is a disable reason, but Sync is still running). Things were working out in practice only because the Android UI code also called RequestStart/Stop as necessary. So, since PSS needs change notifications anyway, let's make that explicit: This CL replaces the callback by a bool, which can be set explicitly. Bug: 867901 Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90 Reviewed-on: https://chromium-review.googlesource.com/c/1269870 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#599195}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .