commit | f448a241361b03dd2b6fd21ab052774e1074fdf1 | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Thu Jul 12 16:13:13 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jul 12 16:13:13 2018 |
tree | 4fc8a9f156167014e15af06b72ba0b1d861e8c99 | |
parent | 9ff6fb086724fb3cd20409d3e72065bbd4a84abd [diff] |
Remove NewTabButton::GetVisibleBounds(). This was a computed by constructing the border path and computing the bounding box. However, it was only used for the ink drop, and ink drops are only used in newer material mode, where the border path is a square. Instead, we can use GetContentsBounds(), as long as those are actually positioned correctly. The new tab button has empty space at the top, which is included (by the tabstrip) in its size and accounted for when doing painting and hittesting. By adding an empty top border of this thickness, a lot of this code can be simplified. (Further simplifications are coming in a subsequent CL.) Bug: none Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe Reviewed-on: https://chromium-review.googlesource.com/1134399 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#574585}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .