Google Git
Sign in
chromium / chromium / src.git / f5fecfdc18d32c229db877c4f0b64c1736b762af
commitf5fecfdc18d32c229db877c4f0b64c1736b762af[log] [tgz]
authorBailey Berro <baileyberro@chromium.org>Wed May 08 19:50:04 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 08 19:50:04 2019
tree189de8a25f1ed89cb7f7f867b45299ff7dcea50d
parent1b1e2ee8601861895613775b4551f948c93c7ab1 [diff]
Split printer installation and printer saving on CupsPrintersManager

This change removes the side effect of saving a printer when it is
marked as installed with CUPS. Printer installation is now separate
from printer saving. Callers are now responsible for calling
SavePrinter() if putting the printer in the saved class is desired.

Bug: 951138
Change-Id: Ice258eeb7ad99f0d8942e3822a6a2f4b0f37249e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577591
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657822}
12 files changed
tree: 189de8a25f1ed89cb7f7f867b45299ff7dcea50d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .