commit | faa579def265753007f87c3ea85a907f0ed469b0 | [log] [tgz] |
---|---|---|
author | Thomas Anderson <thomasanderson@chromium.org> | Tue Dec 18 19:44:53 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 18 19:44:53 2018 |
tree | 39f3427b4eea8cf03995b4371ae9a9e6ae4097f9 | |
parent | 446c78426159cffe11a71580c8586e979c8f3933 [diff] |
Revert "[Reland 1] Use accurate X11 event timestamp computation.""" This reverts commit 2c72cd9089bc3278bf3d2852c971325a9c07f097. Reason for revert: bugs 915277 and 899881 Original change's description: > [Reland 1] Use accurate X11 event timestamp computation."" > > The original CL didn't allow negative time skew from the time server. While this > is likely correct, this caused unit tests to fail as they relied on negative time > skew. This CL allows negative time skew, and also removes another source of > non-determinism from the tests. > > Original change's description: > > Use accurate X11 event timestamp computation. > > > > X events have a timestamp which is only well defined relative to the X11 Server > > time. The previous computation for timestamp for X11 events was making the > > assumption that Server time and Chrome time were the same. This assumption is > > not always true -- this is likely the root cause of "bad" timestamps observed in > > https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 > > > > This CL changes event timestamp computation to make a roundtrip to the X11 > > Server to get an accurate base::TimeTicks. This logic was lifted out of the > > responsiveness calculator, which was already doing this computation. The latter > > will subsequently be changed to use the computation in this CL. > > > > Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 > > Bug: 859155 > > Reviewed-on: https://chromium-review.googlesource.com/1249383 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Erik Chen <erikchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594844} > > Change-Id: I6595f6aa163a18c9724c50546ac8c84bc5c84a03 > Bug: 859155 > Reviewed-on: https://chromium-review.googlesource.com/1252685 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595454} TBR=avi@chromium.org,erikchen@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859155,899881,915277 Change-Id: Ib85a5f5d7bf9469076a334d77ef92771199d6a2d Reviewed-on: https://chromium-review.googlesource.com/c/1382868 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#617593}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .