commit | fcdae8ac98ca623b2f0d6b13376defa2888a1b17 | [log] [tgz] |
---|---|---|
author | Roman Sorokin [CET] <rsorokin@chromium.org> | Fri Jan 11 14:25:37 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 11 14:25:37 2019 |
tree | 23f808fa39666ebc9010e979665dc2bcd3c0b7e2 | |
parent | cc10ceadb80cdd060a804d8989dfbba372899008 [diff] |
Revert "Support IsolatedCodeCache for service worker pass-through responses." This reverts commit cc10ceadb80cdd060a804d8989dfbba372899008. Reason for revert: Broke the build (see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64/50818 ) Original change's description: > Support IsolatedCodeCache for service worker pass-through responses. > > Previously code caching of scripts served from service workers was only > supported if the Response was produced from cache_storage. If the > service worker implemented a pass-through handler like: > > evt.respondWith(fetch(evt.request)) > > Then the v8 compiler could not store or load code cache for the script. > > With IsolatedCodeCache shipping it becomes much simpler to now > support this feature. This CL enables support by: > > 1) Fetching the code cache for service worker controlled scripts. > 2) Allowing the code cache to be used for pass-through responses. > 3) Storing any code cache produced for pass-through responses. > > We still explicitly disable code cache for service worker handlers that > produce either: > > a) Synthetic `new Response()` objects. > b) Response objects produced by `fetch()` to a URL different from the > original request URL. > > Bug: 917414 > Change-Id: I4efdc852a27069d2937056af0133a986e745b2be > Reviewed-on: https://chromium-review.googlesource.com/c/1394740 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621993} TBR=kinuko@chromium.org,mythria@chromium.org,wanderview@chromium.org Change-Id: I966c165c6978121a6ca68823d10ec697d0fa94f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917414 Reviewed-on: https://chromium-review.googlesource.com/c/1406995 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621994}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .