Google Git
Sign in
chromium / chromium / src.git / main
commit8845ea5d6badcd1a4d36860ab14c66800af94a62[log] [tgz]
authorDavid Yeung <dayeung@chromium.org>Tue Dec 16 02:08:51 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 16 02:08:51 2025
tree846b85aac9857eac0284b2ca2970c42fe39d4738
parentfe71375c8ba6419af875f38c270ff9e835161963 [diff]
Reland "Give parent widget a chance to process accelerators"

This reverts commit 71efa534c89c7ca5112738f0b3f790a35c9e8159.

Reason for revert: The regression b/404763413 no longer repros. This CL
will also fix the issues with omnibox AIM popup b/460262043 (keyboard
accelerators are not being forwarded to the parent widget which causes
events like Ctrl+T to not be processed)

Original change's description:
> Revert "Give parent widget a chance to process accelerators"
>
> This reverts commit 4e9b546fe239b04d71cbb6d1f9e155d11dad29ca.
>
> Reason for revert: caused regression: b/404763413
>
> Original change's description:
> > Give parent widget a chance to process accelerators
> >
> > Instead of looking for a bubble dialog delegate to give anchor_widget
> > a chance to handle an accelerator, give the parent widget a chance,
> > and add a virtual method that widget delegate sub-classes can override
> > to prevent this behavior.
> >
> > Bug: 399847951
> > Change-Id: I339bde0afd3100bc3ed216b965130c9287700cd1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318885
> > Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
> > Reviewed-by: Eshwar Stalin <estalin@chromium.org>
> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1428126}
>
> Bug: 399847951
> Change-Id: I86487dd30c9b9a951c1099f101249406cc409c5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372100
> Reviewed-by: Eshwar Stalin <estalin@chromium.org>
> Auto-Submit: David Bienvenu <davidbienvenu@chromium.org>
> Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
> Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1434920}

Bug: 399847951, 460262043
Change-Id: I9cd91c171a5c28adca3c1404486a3d9a6a27e17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7263496
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: David Yeung <dayeung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559103}
2 files changed
tree: 846b85aac9857eac0284b2ca2970c42fe39d4738
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.