Google Git
Sign in
chromium / chromium / src.git / refs/heads/main
commit6027ee538527feff0d15447c221fd2e7a53372a2[log] [tgz]
authorRamin Halavati <rhalavati@google.com>Sat Jun 07 16:16:00 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jun 07 16:16:00 2025
treef6d1d7bd9b7b9a267a0cc23e70926c09f97f8aea
parent441373dc35a644c48e8687d4b91afe7c5d697d29 [diff]
Run PDF Searchify only when needed.

Do not schedule PDF page for searchify when it has no images and do not
start OCR service when no page is scheduled for searchify.

Patchset 1 is the reverted CL http://crrev.com/c/6609060 which failed
on "Win10 Tests x64" trybot which runs the tests with
`--disable-field-trial-config` switch which results in
`PdfViewWebPlugin::DocumentLoadComplete` getting called before any
page is loaded, while the CL assumed the call is done only after all
pages are loaded.

To fix the issue, change the flow to pass OCR service callbacks to
the `PdfiumEngine` in `DocumentLoadComplete` (like before), but make
the first contact with the OCR service only after any page is scheduled
for searchify.

Cq-Include-Trybots: luci.chrome.try:win10-1507-tests-x64

Bug: 421574222
Change-Id: I78ec41463fb00f3d9005a3f2d24959a7fc15c7db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6620821
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1470945}
8 files changed
tree: f6d1d7bd9b7b9a267a0cc23e70926c09f97f8aea
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.