commit | 6027ee538527feff0d15447c221fd2e7a53372a2 | [log] [tgz] |
---|---|---|
author | Ramin Halavati <rhalavati@google.com> | Sat Jun 07 16:16:00 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Jun 07 16:16:00 2025 |
tree | f6d1d7bd9b7b9a267a0cc23e70926c09f97f8aea | |
parent | 441373dc35a644c48e8687d4b91afe7c5d697d29 [diff] |
Run PDF Searchify only when needed. Do not schedule PDF page for searchify when it has no images and do not start OCR service when no page is scheduled for searchify. Patchset 1 is the reverted CL http://crrev.com/c/6609060 which failed on "Win10 Tests x64" trybot which runs the tests with `--disable-field-trial-config` switch which results in `PdfViewWebPlugin::DocumentLoadComplete` getting called before any page is loaded, while the CL assumed the call is done only after all pages are loaded. To fix the issue, change the flow to pass OCR service callbacks to the `PdfiumEngine` in `DocumentLoadComplete` (like before), but make the first contact with the OCR service only after any page is scheduled for searchify. Cq-Include-Trybots: luci.chrome.try:win10-1507-tests-x64 Bug: 421574222 Change-Id: I78ec41463fb00f3d9005a3f2d24959a7fc15c7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6620821 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/main@{#1470945}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.