Google Git
Sign in
chromium / chromium / src / 003be2cc4531f07cd4755a3626f2c2094ec6f8b4
commit003be2cc4531f07cd4755a3626f2c2094ec6f8b4[log] [tgz]
authorPiotr Bialecki <bialpio@chromium.org>Fri May 14 21:29:36 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 14 21:29:36 2021
tree96782621ac4c98a7a85e0a0c88011c000fb80f48
parent2209aa76cb3a83bcd8a05b906cdc5a788d62f2df [diff]
WebXR anchors: fix anchor creation regression

Anchor creation tests used `emulatedPosition==false` as a signal to
determine whether tracking has been established. The CL to fix getPose()
logic (https://crrev.com/c/2803481) subtly changed the behavior and
started returning non-emulated poses if asked about relationship of the
same space w.r.t. itself (it'd return non-emulated identity pose). This
in turn caused the test to attempt to create the anchor when the
tracking is not yet established.

The test case should use a different signal when deciding if the
tracking has been established - for that, querying for a relationship
between local and viewer space should be sufficient. Additionally, fix a
bug with accidentally constructing a base::nullopt where an optional
with default-constructed TransformationMatrix should be returned
instead.

Change-Id: Id1498f57d8303757edaeeaaf883a97b969589ca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897955
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#883136}
3 files changed
tree: 96782621ac4c98a7a85e0a0c88011c000fb80f48
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.