Google Git
Sign in
chromium / chromium / src / 008328c5d48581dff19b2b8b0846f1eb79023737
commit008328c5d48581dff19b2b8b0846f1eb79023737[log] [tgz]
authorluci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>Wed Apr 16 16:24:33 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 16 16:24:33 2025
tree43921a234f087754558a8a1b04a5d300d0738baf
parent1fdca1087c87f8d523a13f67ee71584895681036 [diff]
Revert "Throw within utils.py's run instead of propagating error code"

This reverts commit 9d4f4e592d394e4f785ac7bdb9bfa3db1ce13989.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8717417896286768161

Sample failed build: https://ci.chromium.org/b/8717417896286768161

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6308824&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8717417896286768161&type=BUG

Original change's description:
> Throw within utils.py's run instead of propagating error code
>
> None of the scenarios in which we make use of utils.py's run we can
> recover from that method failing. So, instead of propagating the error
> code, simply let subprocess throw. This improves readability by
> simplifying the code flow.
>
> Change-Id: Id0588f19a80214eaf90fb9d5e2e684c1ca93e7a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308824
> Reviewed-by: Mohannad Farrag <aymanm@google.com>
> Commit-Queue: Stefano Duo <stefanoduo@google.com>
> Cr-Commit-Position: refs/heads/main@{#1447781}
>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I50c241a53d908e49e49946c1a2b8bec5ddbb0fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6463212
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1447794}
4 files changed
tree: 43921a234f087754558a8a1b04a5d300d0738baf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.