Google Git
Sign in
chromium / chromium / src / 00a79eb9427b4001d07ce120dd0774f9993e3355
commit00a79eb9427b4001d07ce120dd0774f9993e3355[log] [tgz]
authorFindit <findit-for-me@appspot.gserviceaccount.com>Sat Aug 21 22:17:01 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Aug 21 22:17:01 2021
tree7cfdb50a91af94493da8169aa446958bd69d79d4
parent7596157614c240fc45544d9d79a1eb42ad704c26 [diff]
Revert "Enable -Wunreachable-code-aggressive in lacros and non-fuchsia chromecast builds"

This reverts commit e6d1f72b6d59360cba5c9c8759a8c1d863127506.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision e6d1f72b6d59360cba5c9c8759a8c1d863127506 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZDFmNzJiNmQ1OTM2MGNiYTVjOWM4NzU5YThjMWQ4NjMxMjc1MDYM

Sample Failed Build: https://ci.chromium.org/b/8838260418218419745

Sample Failed Step: compile

Original change's description:
> Enable -Wunreachable-code-aggressive in lacros and non-fuchsia chromecast builds
> 
> Bug: 1066980
> Change-Id: I73f81c15a1201d18bbc5d5bba32cca219098c6df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111029
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Commit-Queue: Arthur Eubanks <aeubanks@google.com>
> Reviewed-by: Arthur Eubanks <aeubanks@google.com>
> Cr-Commit-Position: refs/heads/main@{#914133}


Change-Id: Ibfda2c636249ad331afe3d009eec4da12d6c186c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112326
Reviewed-by: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#914136}
1 file changed
tree: 7cfdb50a91af94493da8169aa446958bd69d79d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.