Google Git
Sign in
chromium / chromium / src / 00b7fd3fc7d4d4b5dfb1e6e0dfda787e97bf73db
commit00b7fd3fc7d4d4b5dfb1e6e0dfda787e97bf73db[log] [tgz]
authorAlex Chen <alexwchen@chromium.org>Fri Jan 31 00:20:50 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 31 00:20:50 2025
treed2c543dd5303632db674a6ec95be6f32ba44c7df
parent52748403a7d8daca8dbc7767726e9c044d13977a [diff]
[omnibox][search aggregator] Use RichSuggestionImage for aggregator keyword matches

Currently, aggregator keyword matches rely on favicons to fetch the
policy set favicon URL. However, favicons rely on user navigation
to fetch the icon through the history service. As a result,
when a user sets the favicon URL for search aggregator policy,
the icon may never be fetched/used.

RichSuggestionImage requests an image using the bitmap_fetcher_service.
By using RichSuggestionImage, the icon is fetched using the favicon URL
set in the EnterpriseSearchAggregatorSettings policy.

Before: http://screencast/cast/NDk2NTk4MjA0Mzg5Nzg1NnxiOGRlYTU4NS1iNA
After: http://screencast/cast/NTQ3Mjc4MjE3ODU4MjUyOHxiMzZkNzViZS1kNA

Bug: b:380509200
Change-Id: Ie0a3903d973112381f12a92c86aae91bf0d5f83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173646
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Alex Chen <alexwchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413837}
8 files changed
tree: d2c543dd5303632db674a6ec95be6f32ba44c7df
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.