Google Git
Sign in
chromium / chromium / src / 00c380f2c121adcaa00ea4985ca5c947ba962cf5
commit00c380f2c121adcaa00ea4985ca5c947ba962cf5[log] [tgz]
authorFriedrich Horschig <fhorschig@chromium.org>Tue Sep 20 10:51:07 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 20 10:51:07 2022
tree649c999215fd5b00e8b61bb12bfd5d28c947a6e1
parent6b297405fefd0826500840ccce8e984c8ef09062 [diff]
[Android][UPM] Suspend saving for persistent GMS errors

With this change, any authentication error (resolvable and unresolvable)
will set the kSavePasswordsSuspendedByError pref which prevents
users from saving passwords.
To ensure consistent application, the override is applied when querying
the PasswordManagerSettingsService for the value of
PasswordManagerSetting::kOfferToSavePasswords.

The override is reset as soon as the backend completes the first call
to GMS successfully again — e.g. on start or on a pageload.

If the pref is set, the settings service returns that offer to save
passwords is turned off.

If the user is unenrolled or leaves the experiment, the pref becomes
inactive.

The pref is not synced. It's false by default and is always set by the
latest PasswordStoreAndroidBackend to retrieve logins.

Bug: 1352415, 1364084
Change-Id: Ic1ed611693b982fa01d1ab2dc233d3e12f8f0a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899116
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1049030}
8 files changed
tree: 649c999215fd5b00e8b61bb12bfd5d28c947a6e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.