Reland "Implement WebContents discard by clearing the primary frame document"

This is a reland of commit ce4ea2692091b299b26cc7967f9e1b980c583e09

See diff against PS1.

Addressed timeout issue in DiscardClearsDedicatedWorkers test.
Destruction of blink::DedicatedWorker post Discard() relies on
async GC sweep in V8, which can result in timeouts on bots.

Updated extension tab loading status to report unloaded when the
tab is discarded. The tab will retain its render process when
discarded with the new mechanism (consistent with previous behavior).

Original change's description:
> Implement WebContents discard by clearing the primary frame document
>
> See go/discard-frame-tree for additional details and to contribute
> to discussion.
>
> This carries on from fdoray's prototype (crrev.com/c/4060064) and
> erik's follow up (crrev.com/c/5454457).
>
> This CL introduces a new discard mechanism that avoids needing
> to replace the tab's WebContents.
>
> Discard works by clearing the primary frame tree, done via replacing
> Blink's primary document. This frees resources associated with the
> primary frame and clears away any child frames attached to the
> frame tree.
>
> Discard does not result in creation of any session entries and does
> not emit navigation-related events
>
> Key changes:
>  - Update TabLifecycleUnit::FinishDiscard to no longer create
>    a empty WebContents for the discard operation. Instead discard
>    is implemented via replacing the primary blink document
>
>  - The tab thumbnail implementation has been updated to handle the
>    new discard mechanism
>
>  - OneTimePermissionsTrackerHelper was updated to leverage the
>    existing WebContents observation instead of relying on
>    TabLifecycleObserver
>
>  - Multiple test updates / fixes to reflect discard API changes
>    and address incorrect assumptions (active tabs cannot be
>    discarded)
>
> Notifications for discard events with both the old and new
> WebContents from the original API remain. These can be removed or
> refactored in the follow up CLs.
>
> PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests &&
> out/Default/bin/run_perfetto_diff_tests`
>
> Bug: 347770670
> Change-Id: I32e87b2b992914a7ae0e0bbdddf78f1b27c5773b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637909
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Nicolás Peña <npm@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Victor Vianna <victorvianna@google.com>
> Reviewed-by: Florian Jacky <fjacky@chromium.org>
> Reviewed-by: David Pennington <dpenning@chromium.org>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1343920}

Bug: 347770670
Change-Id: Idba13fec3c375c9f88727826386729963bef9166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799663
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Florian Jacky <fjacky@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345153}
69 files changed
tree: 511cf9e32e84edbb5c5c0b9508fee7305ebde2d8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.