Revert "Match prefetches against render requests" This reverts commit 74fb3b3d2ce4a37d407ee8e939fa53fb5e4aad45. Reason for revert: New unit tests are failing in the following builder: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/123028/overview Original change's description: > Match prefetches against render requests > > Call the matching code from PrefetchMatchingURLLoaderFactory. If the > newly-added "NetworkContextPrefetchUseMatches" feature is enabled, also > allow successful matches to be consumed by the renderer. Otherwise, only > the histograms indicating matching success or failure will be logged. > The prefetch is abandoned after a delay but the renderer may still > be able to use the disk cache entry it created. > > Add check that the `request_initiator` is valid so that the render > process cannot bypass access checks when a prefetch is matched. > > Rename the SetClient() method of network::PrefetchURLLoaderClient to > Consume() and make it take a PendingReceiver<URLLoader> argument. The > CorsURLLoader that the client is bound to is rebound to the passed-in > argument, permitted it to be called from the render process directly. > Add a Matches() method which calls PrefetchMatches() against the stored > ResourceRequest. > > Also refactor the PrefetchURLLoaderClient tests to provide a more > realistic environment. > > Currently tests that call Consume() leak memory and so are disabled on > sanitizer builds. See https://crbug.com/375425822. This memory leak only > happens if the "NetworkContextPrefetchUseMatches" feature is enabled and > will be fixed before that is used in production. > > BUG=342445996 > > Low-Coverage-Reason: TESTS_IN_SEPARATE_CL Uncovered code has no callers yet. > Change-Id: I607db0dbbf8017730b56de3baa4d66d2b15268ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5715614 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1374542} Bug: 342445996, 375425822 Change-Id: I7293583afc1f1d0291b693b2e1f47f3d492adcdb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5971793 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Felipe Andrade <fsandrade@chromium.org> Owners-Override: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/main@{#1374591}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.