Google Git
Sign in
chromium / chromium / src / 0113e400d968b081380dfe477bd4c4b7eaa45e6b
commit0113e400d968b081380dfe477bd4c4b7eaa45e6b[log] [tgz]
authorTimofey Chudakov <tchudakov@google.com>Wed Apr 10 16:36:39 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 10 16:36:39 2024
tree4f54086304b09f52f57787bc89653047e39199cd
parent2dc0a4c57d8119c45e89d7fc4dd7e1a103c87fe1 [diff]
[Mullhet] Do not filter grouped credentials in logins handler.

This CL removes filtering of the grouped credentials from the
GetLoginsWithAffiliationsRequestHandler. It concludes a series of
changes that move the filtering of grouped credentials to the caller
side. The list of callers and CLs is following:
* PasswordReceiverServiceImpl
  CL: crrev.com/c/5402733
* CredentialManagerPendingPreventSilentAccessTask
  CL: crrev.com/c/5432262.
* InsecureCredentialHelper
  CL: crrev.com/c/5434993.
* FormFetcherImpl
  CL: crrev.com/c/5419670.
* HttpPasswordStoreMigrator
  No changes needed because only exact matches are processed.

By now, all of the above callers should be able to handle grouped
credentials in a correct way.

Bug: b/331409076
Change-Id: Ia2df7eab5da8089c2adfa19874df50730cf1ba8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5419318
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Timofey Chudakov <tchudakov@google.com>
Cr-Commit-Position: refs/heads/main@{#1285183}
3 files changed
tree: 4f54086304b09f52f57787bc89653047e39199cd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.