Google Git
Sign in
chromium / chromium / src / 0147ff2d559c7656ccf5caa0b7839d8f73e357f1
commit0147ff2d559c7656ccf5caa0b7839d8f73e357f1[log] [tgz]
authorBen Becker <benbecker@chromium.org>Thu Feb 23 23:19:30 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 23 23:19:30 2023
tree1d311b5e4e4cdf413f1d7619759d8ae611f5daf2
parent1a4b971a3e3447d2ea741b7407df2d6ae232f23d [diff]
CloseAll: Prevent closing a window without a widget

This CL avoids closing a window with a null widget. This is due to an
issue that was discovered with ARC windows where it is possible that ARC
windows will not have a widget while the window is still alive. Thus,
when we try to call CloseNow on the widget in the DesksController, we
create a crash. This CL fixes this by only calling CloseNow on the
widget when the widget exists, and otherwise it posts a delayed task to
generate a UMA log one minute later indicating the number of windows
that still haven't closed. This way, we can check back to ensure that
the windows without widgets eventually close.

Bug: b/265095206
Change-Id: I7f2c6f507e4769a2d5274c8204f816785accba6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278303
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Ben Becker <benbecker@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109283}
2 files changed
tree: 1d311b5e4e4cdf413f1d7619759d8ae611f5daf2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.