Only trigger VR version errors on changes

While testing "git cl presubmit --all" I found these errors appearing:

    Must increment version in 'chrome\browser\resources\vr\assets\VERSION' when updating VR assets.
    Must not downgrade version in 'chrome\browser\resources\vr\assets\VERSION'.

The trouble is that these errors appear even if no assets or version
numbers have been updated. In order to facilitate clean presubmit --all
runs this change adds detection of whether there are any diffs in the
file by calling file.ChangedContents() in one case and comparing the
version numbers in the other case.

This errors could most efficiently be provoked with this command:

    git cl presubmit --files=chrome\browser\resources\vr\assets\vr_assets_component_files.json;chrome\browser\resources\vr\assets\VERSION

Now they can only be provoked if you actually modify and commit either
those files or one of the .sha1 files.

Bug: 1309977
Change-Id: Ia6a8a103cb0b4d0ac258c704a637a1a7c9104159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606569
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996470}
1 file changed
tree: 853c29ebefd740cea8e62dff869cecec256f0df8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.