commit | 0149cac93f2d13ee9f371abed615096ce4225e9b | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Wed Apr 27 01:32:32 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 27 01:32:32 2022 |
tree | 853c29ebefd740cea8e62dff869cecec256f0df8 | |
parent | f6153ebbbacafccc10cb700b1cce9be056480490 [diff] |
Only trigger VR version errors on changes While testing "git cl presubmit --all" I found these errors appearing: Must increment version in 'chrome\browser\resources\vr\assets\VERSION' when updating VR assets. Must not downgrade version in 'chrome\browser\resources\vr\assets\VERSION'. The trouble is that these errors appear even if no assets or version numbers have been updated. In order to facilitate clean presubmit --all runs this change adds detection of whether there are any diffs in the file by calling file.ChangedContents() in one case and comparing the version numbers in the other case. This errors could most efficiently be provoked with this command: git cl presubmit --files=chrome\browser\resources\vr\assets\vr_assets_component_files.json;chrome\browser\resources\vr\assets\VERSION Now they can only be provoked if you actually modify and commit either those files or one of the .sha1 files. Bug: 1309977 Change-Id: Ia6a8a103cb0b4d0ac258c704a637a1a7c9104159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606569 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#996470}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.