Google Git
Sign in
chromium / chromium / src / 0161fe98675f99d74de0aaa8d8d07022a441bd82
commit0161fe98675f99d74de0aaa8d8d07022a441bd82[log] [tgz]
authorDavid Pennington <dpenning@chromium.org>Sun Jun 26 21:34:19 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Jun 26 21:34:19 2022
tree2806a5a10bb73a5636784ca0fd9f9626a41f2873
parent5a2149ad05fb4a4ac24cbe0da4cc01f8252e6dcd [diff]
Remove the TabStripModelOrderController

The TabStripModelOrderController is a special observer in the
TabStripModel which calls functions directly in the model to update the
openers of tabs, as well as decide where to insert new tabs. The only
usage of the TabStripModelOrderController is in TabStripModel, and does
not have any internal state, instead serving as a way to call code from
an observer and a couple of helper methods.

This doesnt meet the separation of responsibilities requirement of moving logic out to its own class, therefore its being moved into tabstripmodel.

Change-Id: Ib5a6c50f451bad01ca6305ed72ec18b51cac7964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703786
Commit-Queue: David Pennington <dpenning@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018063}
6 files changed
tree: 2806a5a10bb73a5636784ca0fd9f9626a41f2873
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.